Photos

Merge lp://qastaging/~djaler1/pantheon-photos/fix-1405890 into lp://qastaging/~pantheon-photos/pantheon-photos/trunk

  1. fix-1405890
  2. Merge into trunk
Proposed by Kirill Romanov
Status: Merged
Approved by: Danielle Foré
Approved revision: 3102
Merged at revision: 3113
Proposed branch: lp://qastaging/~djaler1/pantheon-photos/fix-1405890
Merge into: lp://qastaging/~pantheon-photos/pantheon-photos/trunk
Diff against target: 61 lines (+33/-12)
1 file modified
src/direct/DirectPhotoPage.vala (+33/-12)
To merge this branch: bzr merge lp://qastaging/~djaler1/pantheon-photos/fix-1405890
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Review via email: mp+314004@code.qastaging.launchpad.net

Commit message

Make Ctrl + S work in the photo viewer

Description of the change

Fix bug #1405890

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

I can confirm that this works as expected :)

review: Approve
Revision history for this message
Corentin Noël (tintou) wrote :

As a side note, instead of doing this (event.state & Gdk.ModifierType.CONTROL_MASK) != 0
The vala language allows you to do `if (Gdk.ModifierType.CONTROL_MASK in event.state)` with flags which is much more graceful and easier to recognize at first sight ;)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: