Humanity

Merge lp://qastaging/~dmj726/humanity/hidpi-2x into lp://qastaging/~ubuntu-art-pkg/humanity/release

  1. hidpi-2x
  2. Merge into release
Proposed by David Jordan
Status: Merged
Merged at revision: 127
Proposed branch: lp://qastaging/~dmj726/humanity/hidpi-2x
Merge into: lp://qastaging/~ubuntu-art-pkg/humanity/release
Diff against target: 1095 lines (+570/-0)
3 files modified
Humanity-Dark/index.theme (+126/-0)
Humanity/index.theme (+438/-0)
debian/changelog (+6/-0)
To merge this branch: bzr merge lp://qastaging/~dmj726/humanity/hidpi-2x
Reviewer Review Type Date Requested Status
Iain Lane Approve
Review via email: mp+315411@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2017-01-19.

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote : Posted in a previous version of this proposal

Thanks, this is great! I knew about the problem but somehow it never got to the top of my list to fix, so I really appreciate this. Four mostly administrative/tweaking requests:

  - Please add the new entries to ScaledDirectories (see the spec[0]) instead of Directories.
  - Please call the new directories "@2" instead of "@2x"; this is what we used for hidpi icons in the Ubuntu themes (for interface elements) - it would be good to be consistent with that. Not *super* important if you feel strongly about "@2x".
  - If you agree, I think we should SRU these to at least 16.04 and 16.10 - could you please update the bug(s) to have the required SRU template information from [1]?
  - Please write a changelog entry in debian/changelog (use `dch' and make sure $DEBFULLNAME and $DEBEMAIL are set in the environment - version for zesty should be 0.6.12), so you get properly credited.

[0] https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
[1] https://wiki.ubuntu.com/StableReleaseUpdates#Procedure

review: Needs Fixing
Revision history for this message
David Jordan (dmj726) wrote :

Thanks Iain, I've made the changes you requested. For the SRU, do you think we should backport the latest trunk or apply these changes to the old versions of index.theme?

Revision history for this message
Iain Lane (laney) wrote :

There's only one other change, which AFAIK doesn't apply to xenial, so we can just cherry-pick this revision IMHO.

Think this looks good now - just going to test and then upload to zesty. Thanks again.

review: Approve
Revision history for this message
Iain Lane (laney) wrote :

Ok, once the bugs are updated to fit the SRU template, I can upload to 16.04 and 16.10.

review: Approve
Revision history for this message
David Jordan (dmj726) wrote :

Okay, the bugs are updated to fit the SRU template.

Revision history for this message
David Jordan (dmj726) wrote :

This would be good to land in time for the 16.04.2 iso, so hidpi machines don't have a buggy-looking installer.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches