Linaro Android Build Tools

Merge lp://qastaging/~doanac/linaro-android-build-tools/user-script-kernel into lp://qastaging/linaro-android-build-tools

  1. user-script-kernel
  2. Merge into trunk
Proposed by Andy Doan
Status: Merged
Approved by: Paul Sokolovsky
Approved revision: 430
Merged at revision: 429
Proposed branch: lp://qastaging/~doanac/linaro-android-build-tools/user-script-kernel
Merge into: lp://qastaging/linaro-android-build-tools
Diff against target: 148 lines (+120/-0)
4 files modified
build-scripts/build-android (+1/-0)
build-scripts/create-user-kernel-script (+91/-0)
build-scripts/repo_project_info.py (+27/-0)
utils/mangle-jobs/update-push-artifacts.mangle (+1/-0)
To merge this branch: bzr merge lp://qastaging/~doanac/linaro-android-build-tools/user-script-kernel
Reviewer Review Type Date Requested Status
Paul Sokolovsky Approve
Review via email: mp+98461@code.qastaging.launchpad.net

Description of the change

This change is very similar to the change that produces an android build script for the user. In this case the script produced will build the kernel.

To post a comment you must log in.
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Well, if script is generic and called repo_project_info.py, it's better not to have defaults, but to call it with explicit param all the time to avodi confusion, can you change that please?

review: Needs Fixing
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Btw, it's not too hard to skip repo dependency and read manifest with python's minidom, but up to you.

lp://qastaging/~doanac/linaro-android-build-tools/user-script-kernel updated
430. By Andy Doan

require argument for repo project

Ensure the repo_project_info.py doesn't do anything automatic
for you. The caller should be explicit in what project it wants

Revision history for this message
Andy Doan (doanac) wrote :

> Btw, it's not too hard to skip repo dependency and read manifest with python's
> minidom, but up to you.
yeah,but this was so easy and the other doing the xml myself seemed more likely to have some unforseen error if someone did something exotic with their manifest.xml

Revision history for this message
Andy Doan (doanac) wrote :

> Well, if script is generic and called repo_project_info.py, it's better not to
> have defaults, but to call it with explicit param all the time to avodi
> confusion, can you change that please?

Sure - code has been updated. Let me know what you think.

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Looks good, thanks for the changes.

review: Approve
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Mangle script also run.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches