linaro-license-protection

Merge lp://qastaging/~doanac/linaro-license-protection/prebuilt-support into lp://qastaging/~linaro-automation/linaro-license-protection/trunk

  1. prebuilt-support
  2. Merge into trunk
Proposed by Andy Doan
Status: Merged
Merged at revision: 52
Proposed branch: lp://qastaging/~doanac/linaro-license-protection/prebuilt-support
Merge into: lp://qastaging/~linaro-automation/linaro-license-protection/trunk
Diff against target: 90 lines (+39/-3)
2 files modified
scripts/publish_to_snapshots.py (+9/-2)
testing/test_publish_to_snapshots.py (+30/-1)
To merge this branch: bzr merge lp://qastaging/~doanac/linaro-license-protection/prebuilt-support
Reviewer Review Type Date Requested Status
Guilherme Salgado (community) Approve
Review via email: mp+99776@code.qastaging.launchpad.net

Description of the change

This allows pre-built images to be published

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

found a small bug. I need to fix before this can be merged.

lp://qastaging/~doanac/linaro-license-protection/prebuilt-support updated
51. By Andy Doan

fix layout issue for prebuilt

The original commit for pre-built layouts assumed jenkins could
pass something like 20120328. This isn't known by jenkins so we
instead change the layout to use jobname and build number.

Revision history for this message
Andy Doan (doanac) wrote :

> found a small bug. I need to fix before this can be merged.
Its been fixed by commit 51. Code is ready for review again.

Revision history for this message
Guilherme Salgado (salgado) wrote :

It looks reasonable to me. Can you add a test for it in testing/test_publish_to_snapshots.py? From what I can tell it should be easy but if it turns out to be tricky we can file a bug to have one added later.

review: Approve
lp://qastaging/~doanac/linaro-license-protection/prebuilt-support updated
52. By Andy Doan

add test code for prebuilt

Revision history for this message
Andy Doan (doanac) wrote :

On 03/28/2012 01:07 PM, Guilherme Salgado wrote:
> Review: Approve
>
> It looks reasonable to me. Can you add a test for it in testing/test_publish_to_snapshots.py? From what I can tell it should be easy but if it turns out to be tricky we can file a bug to have one added later.

test case added.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches