Phablet Tools

Merge lp://qastaging/~doanac/phablet-tools/phablet-device into lp://qastaging/phablet-tools

  1. phablet-device
  2. Merge into trunk
Proposed by Andy Doan
Status: Rejected
Rejected by: Sergio Schvezov
Proposed branch: lp://qastaging/~doanac/phablet-tools/phablet-device
Merge into: lp://qastaging/phablet-tools
Diff against target: 307 lines (+268/-4)
4 files modified
phablet-device (+158/-0)
phabletutils/device.py (+0/-1)
setup.py (+4/-3)
tests/test_phablet_device.py (+106/-0)
To merge this branch: bzr merge lp://qastaging/~doanac/phablet-tools/phablet-device
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Sergio Schvezov Needs Fixing
Review via email: mp+189449@code.qastaging.launchpad.net

Commit message

Add phablet-device command to abstract usage of adb

In the future we'll be moving away from ADB. This changeset adds a new "phablet-device" command
that provides adb equivalents. Test writers can use this new API. Then when the move away from
adb occurs, the only thing we'll need to change is the implementation of phablet-device.

Description of the change

Add phablet-device command to abstract usage of adb

In the future we'll be moving away from ADB. This changeset adds a new "phablet-device" command
that provides adb equivalents. Test writers can use this new API. Then when the move away from
adb occurs, the only thing we'll need to change is the implementation of phablet-device.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:207
http://10.97.0.26:8080/job/phablet-tools-ci/202/
Executed test runs:
    FAILURE: http://10.97.0.26:8080/job/phablet-tools-saucy-amd64-ci/145/console
    FAILURE: http://10.97.0.26:8080/job/phablet-tools-saucy-armhf-ci/145/console
    FAILURE: http://10.97.0.26:8080/job/phablet-tools-saucy-i386-ci/146/console

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/phablet-tools-ci/202/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~doanac/phablet-tools/phablet-device updated
208. By Andy Doan

make the phablet-device python2.7

The unit tests run as 2.7. Its a simple conversion in the future
to make the python3 friendly.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:208
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/217/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-amd64-ci/160
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-armhf-ci/160
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-i386-ci/161

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/phablet-tools-ci/217/rebuild

review: Approve (continuous-integration)
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

94 +def _drain(p):

Can you add some docstrings to this?

review: Needs Fixing
lp://qastaging/~doanac/phablet-tools/phablet-device updated
209. By Andy Doan

add documentation for the _drain function

Revision history for this message
Andy Doan (doanac) wrote :

> 94 +def _drain(p):
>
> Can you add some docstrings to this?

I added some documentation. I'm sure there are other ways this could be done and my approach might be a bit odd. I'm happy to take suggestions.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:209
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/229/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-amd64-ci/1
    FAILURE: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-armhf-ci/1/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-i386-ci/1

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/phablet-tools-ci/229/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~doanac/phablet-tools/phablet-device updated
210. By Andy Doan

backout logging change (being fixed in another branch already)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:210
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/236/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-armhf-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-i386-ci/8

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/phablet-tools-ci/236/rebuild

review: Approve (continuous-integration)

Unmerged revisions

210. By Andy Doan

backout logging change (being fixed in another branch already)

209. By Andy Doan

add documentation for the _drain function

208. By Andy Doan

make the phablet-device python2.7

The unit tests run as 2.7. Its a simple conversion in the future
to make the python3 friendly.

207. By Andy Doan

add unit-test for phablet-device

just add some sanity checks for:

a) ensuring device serial is dealt with correctly
b) ensure phablet-device shell handles errors and output correctly

206. By Andy Doan

add a "phablet-device list" call to list attached devices

205. By Andy Doan

add "phablet-device shell" command

204. By Andy Doan

add a "phablet-device reboot|wait-for-device" commands

203. By Andy Doan

add a "phablet-device push" command

202. By Andy Doan

add a phablet-device pull command

201. By Andy Doan

create skeleton for a phablet-device command

this will be the basis for extending new options like push, pull, etc

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches