Merge lp://qastaging/~doanac/qa-dashboard/bad-crash-counts into lp://qastaging/qa-dashboard

Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 717
Merged at revision: 717
Proposed branch: lp://qastaging/~doanac/qa-dashboard/bad-crash-counts
Merge into: lp://qastaging/qa-dashboard
Diff against target: 227 lines (+119/-44)
2 files modified
smokeng/tests.py (+57/-0)
smokeng/views.py (+62/-44)
To merge this branch: bzr merge lp://qastaging/~doanac/qa-dashboard/bad-crash-counts
Reviewer Review Type Date Requested Status
Joe Talbott Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+205870@code.qastaging.launchpad.net

Commit message

fix bad crash-count logic for summary page

We were accidentally counting crashes from prior jenkins jobs when
newer ones had improved results. The refactoring of the
smokeng.views.overview was just done so that it would be possible to
test the "get_totals" API easier.

Description of the change

fix bad crash-count logic for summary page

We were accidentally counting crashes from prior jenkins jobs when
newer ones had improved results. The refactoring of the
smokeng.views.overview was just done so that it would be possible to
test the "get_totals" API easier.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:717
http://s-jenkins.ubuntu-ci:8080/job/dashboard-ci/301/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dashboard-ci/301/rebuild

review: Approve (continuous-integration)
Revision history for this message
Joe Talbott (joetalbott) wrote :

+1 for getting rid of that nested loop.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches