Ubuntu Test Cases

Merge lp://qastaging/~doanac/ubuntu-test-cases/bootchart into lp://qastaging/ubuntu-test-cases/touch

  1. bootchart
  2. Merge into touch
Proposed by Andy Doan
Status: Merged
Merged at revision: 221
Proposed branch: lp://qastaging/~doanac/ubuntu-test-cases/bootchart
Merge into: lp://qastaging/ubuntu-test-cases/touch
Diff against target: 147 lines (+98/-1)
7 files modified
jenkins/templates/touch-base.xml.jinja2 (+1/-1)
jenkins/testconfig.py (+2/-0)
tests/bootspeed/bootchart/run.py (+73/-0)
tests/bootspeed/bootchart/setup.sh (+4/-0)
tests/bootspeed/bootchart/tc_control (+12/-0)
tests/bootspeed/master.run (+5/-0)
tests/bootspeed/tslist.run (+1/-0)
To merge this branch: bzr merge lp://qastaging/~doanac/ubuntu-test-cases/bootchart
Reviewer Review Type Date Requested Status
Paul Larson Approve
Review via email: mp+216945@code.qastaging.launchpad.net

Description of the change

adds support for ogra's boot chart work to get executed after our daily image testing

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

+ os.mkdir('/tmp/results')
If I'm reading this right, this runs on the host correct? Since the possibility exists that this could be running for more than one device at the same time, we should really use mkdtemp or similar.

review: Needs Fixing
Revision history for this message
Andy Doan (doanac) wrote :

> + os.mkdir('/tmp/results')
> If I'm reading this right, this runs on the host correct? Since the
> possibility exists that this could be running for more than one device at the
> same time, we should really use mkdtemp or similar.

The full snippet is:

103 + if os.path.exists('/tmp/results'):
104 + shutil.rmtree('/tmp/results')
105 + os.mkdir('/tmp/results')

So we clean it if needed. the problem is the jenkins job needs to know a fixed location to grab these files from, so this was the cheapest way to deal with it :/

lp://qastaging/~doanac/ubuntu-test-cases/bootchart updated
221. By Andy Doan

fix results directory handling

as per review by Paul

222. By Andy Doan

results are created by utah as root so sudo to clear workspace

Revision history for this message
Paul Larson (pwlars) wrote :

Great idea to use the UTAH_PROBE_DIR
+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches