Merge lp://qastaging/~doanac/uci-engine/bsb-throttle-message into lp://qastaging/uci-engine

Proposed by Andy Doan
Status: Merged
Approved by: Francis Ginther
Approved revision: 452
Merged at revision: 490
Proposed branch: lp://qastaging/~doanac/uci-engine/bsb-throttle-message
Merge into: lp://qastaging/uci-engine
Diff against target: 42 lines (+19/-2)
2 files modified
branch-source-builder/bsbuilder/run_worker.py (+1/-1)
ci-utils/ci_utils/amqp_utils.py (+18/-1)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/bsb-throttle-message
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Andy Doan (community) Needs Resubmitting
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+217097@code.qastaging.launchpad.net

Commit message

bsbuilder: better throttling of the status updates

We are flooding the log with the same status message over
and over. This helps throttle this back a bit so that we
still see updates and can tell things aren't stuck, but also
not flood out log files. I added this in a generic way
to amqp_utils so that other people can choose to join in
if they ever find the need.

Description of the change

I noticed this while working on my "live logging" feature. The bsbuilder is dumping a message over and over and I've added support to throttle how often we show it.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:451
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/537/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/537/rebuild

review: Approve (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

What's the purpose of _ratelimit['data']?

review: Needs Information
Revision history for this message
Andy Doan (doanac) wrote :

> What's the purpose of _ratelimit['data']?

good catch. when I started this i thought about comparing "data" from call to call. if it changed then not enforce the ratelimit, but it made it get out of hand. I'll remove that.

452. By Andy Doan

remove unused value

as per fginther's review

Revision history for this message
Andy Doan (doanac) :
review: Needs Resubmitting
Revision history for this message
Francis Ginther (fginther) wrote :

All good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches