Merge lp://qastaging/~doanac/uci-engine/db-workflow into lp://qastaging/uci-engine

Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 505
Merged at revision: 542
Proposed branch: lp://qastaging/~doanac/uci-engine/db-workflow
Merge into: lp://qastaging/uci-engine
Diff against target: 378 lines (+147/-14)
11 files modified
lander/bin/lander_process_ticket.py (+4/-2)
lander/lander/run_worker.py (+2/-1)
lander/lander/tests/test_process_ticket.py (+10/-1)
lander/lander/tests/test_service_wrapper.py (+11/-1)
lander/lander/workflow.py (+3/-7)
ticket_system/setup.py (+1/-0)
ticket_system/ticket/admin.py (+7/-1)
ticket_system/ticket/management/__init__.py (+28/-0)
ticket_system/ticket/migrations/0002_uce0.py (+25/-1)
ticket_system/ticket/models.py (+41/-0)
ticket_system/ticket/tests/test_models.py (+15/-0)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/db-workflow
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Evan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
William Grant Pending
Review via email: mp+220708@code.qastaging.launchpad.net

Commit message

ticket-system: add concept of "workflow"

We have a "todo" in our lander to get the workflow for a ticket
from the ticket-system. This adds a new table that we can store
support workflow-steps in. We'll assign all tickets a workflow. We'll
keep a "default" one for convienice and have django create it
during our initial migration. But over time we could add/remove/change
these workflows based on CI train needs

Description of the change

We've had a TODO in the lander to move its fixed "workflow steps" into the ticket system. This moves the definition into the ticket-system so that we'll be able to set different types of ticket workflows (ie we could add traincon-1 workflow).

This just gets the foundation going. There will be a series of follow-up MPs that will use this new function.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:503
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/682/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/682/rebuild

review: Needs Fixing (continuous-integration)
504. By Andy Doan

fix broken test. this was somehow done in one the downstream branches but not here.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:504
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/757/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/757/rebuild

review: Needs Fixing (continuous-integration)
505. By Andy Doan

merge with trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:505
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/758/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/758/rebuild

review: Approve (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

I just have some questions. If these aren't anything of concern, then I'll approve.

review: Needs Information
Revision history for this message
Evan (ev) wrote :

Questions about the data model with JSON as an inline comment.

review: Needs Information
Revision history for this message
Andy Doan (doanac) wrote :

response to fginther

Revision history for this message
Andy Doan (doanac) wrote :

response to ev/fginther

Revision history for this message
Evan (ev) wrote :

Looks good. Chatted with Andy on IRC and he confirmed that this raising an exception in failing to parse the json will result in the ticket not being created/updated with the bogus data, which we can presumably feed back to the UI.

review: Approve
Revision history for this message
Francis Ginther (fginther) wrote :

Andy, thanks for the follow-up, I also approve.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches