Merge lp://qastaging/~doanac/uci-engine/deploy.py-stack-name into lp://qastaging/uci-engine

Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 630
Merged at revision: 630
Proposed branch: lp://qastaging/~doanac/uci-engine/deploy.py-stack-name
Merge into: lp://qastaging/uci-engine
Diff against target: 45 lines (+7/-4)
1 file modified
juju-deployer/deploy.py (+7/-4)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/deploy.py-stack-name
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Celso Providelo (community) Approve
Review via email: mp+224898@code.qastaging.launchpad.net

Commit message

deploy.py: make juju-deployer "stack" configurable

This allows us to mix in new juju-deployer files like "experimenatal"

Description of the change

The non-functional stuff deploys to trusty. We need juju-deployer to support mixed deployments:

 https://code.launchpad.net/~doanac/juju-deployer/multiple-series

For now we'll allow overriding what this "stack" is to deployer and the non-function MP can just call their stack "ci-airline-experimental" or something.

NOTE: this will still be a single deployment. Juju has no knowledge of these "stacks", so you could still add relations between them and such.

In some ways, this is just a generally useful feature.

To post a comment you must log in.
Revision history for this message
Celso Providelo (cprov) wrote :

LGTM, Later on we can catch up on tests, since a lot of things are going to change in deploy.py with mojo.

Running `deploy.py --build-only -n <name>` should expose any problem.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:630
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/961/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/961/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches