Ubuntu CI Engine

Merge lp://qastaging/~doanac/uci-engine/django-upgrade into lp://qastaging/uci-engine

  1. django-upgrade
  2. Merge into trunk
Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 541
Merged at revision: 548
Proposed branch: lp://qastaging/~doanac/uci-engine/django-upgrade
Merge into: lp://qastaging/uci-engine
Diff against target: 181 lines (+52/-87)
1 file modified
charms/precise/python-django/hooks/hooks.py (+52/-87)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/django-upgrade
Reviewer Review Type Date Requested Status
Francis Ginther Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+222263@code.qastaging.launchpad.net

Commit message

django charm: get upgrade path consistent with install

We noticed a bug where the upgrade path doesn't install packages
if the config changed to include new ones. This makes changes the
upgrade path to use the install path.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:540
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/788/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/788/rebuild

review: Approve (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

A couple of inline comments.

review: Needs Fixing
lp://qastaging/~doanac/uci-engine/django-upgrade updated
541. By Andy Doan

oops and oops

forgot to include logic to perform a db migration during upgrade.

also fix a runtime error caught be fginther

Revision history for this message
Andy Doan (doanac) wrote :

nice review. comments inline

I also noticed our upgrade path wasn't performing South DB migrations. That's been fixed in r540 as well. Things should be in good shape now

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:541
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/798/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/798/rebuild

review: Approve (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Gah! I missed config_changed being called in the upgrade path. Approve.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches