Merge lp://qastaging/~doanac/uci-engine/engine-health-revno into lp://qastaging/uci-engine

Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 536
Merged at revision: 536
Proposed branch: lp://qastaging/~doanac/uci-engine/engine-health-revno
Merge into: lp://qastaging/uci-engine
Prerequisite: lp://qastaging/~vila/uci-engine/more-payload
Diff against target: 131 lines (+34/-16)
6 files modified
ci-utils/ci_utils/json_status.py (+11/-0)
gatekeeper/gatekeeper/resources/tests/test_api.py (+8/-2)
gatekeeper/gatekeeper/resources/v1.py (+1/-0)
juju-deployer/deploy.py (+11/-14)
lander/bin/json_status_cgi.py (+1/-0)
ppa-assigner/ppa_assigner/api.py (+2/-0)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/engine-health-revno
Reviewer Review Type Date Requested Status
Evan (community) Approve
Vincent Ladeuil (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+222066@code.qastaging.launchpad.net

Commit message

engine-health: include revision level for components

Include branch/revno information in our engine health page for the
services we have that expose json-status. This doesn't account for
our rabbit-workers, but should be a nice, helpful start.

Description of the change

This allows us to show what code level our various components are at in the engine-health page. It looks roughly like:

-------------------------------------------------------------------------------------------
| ci-airline-lander/0 | * lander worker: ci_airline_lander start/running, process 10152 |
| | * revision: engine-revision@533 - 2014-06-04 11:28:06 +0200 |

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:534
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/773/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/773/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Evan (ev) wrote :

There is a better way :)

review: Needs Fixing
Revision history for this message
Vincent Ladeuil (vila) wrote :

There is a simpler way that allow creating the data just as you want from the start removing the need to parse it later.

review: Needs Fixing
535. By Andy Doan

use vila's suggestion to simplify

Revision history for this message
Andy Doan (doanac) wrote :

vila: good suggestion. revno 535 is a lot cleaner now.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:535
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/776/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/776/rebuild

review: Needs Fixing (continuous-integration)
536. By Andy Doan

fix broken unit test

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:536
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/778/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/778/rebuild

review: Approve (continuous-integration)
Revision history for this message
Vincent Ladeuil (vila) wrote :

Gee, indeed, a lot cleaner and easier to read ! Well done !

review: Approve
Revision history for this message
Vincent Ladeuil (vila) :
Revision history for this message
Evan (ev) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches