Merge lp://qastaging/~doanac/uci-engine/false-comment into lp://qastaging/uci-engine

PASSED: Continuous integration, rev:497
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/661/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/661/rebuild

On May 20, 2014 5:54 PM, "Andy Doan" <email address hidden> wrote:
>
> Andy Doan has proposed merging lp:~doanac/uci-engine/false-comment into
lp:uci-engine.
>
> Commit message:
> remove incorrect comment about ticket-states
>
> this comment is incorrect and just leads to confusion
>
> Requested reviews:
> Canonical CI Engineering (canonical-ci-engineering)
>
> For more details, see:
> https://code.launchpad.net/~doanac/uci-engine/false-comment/+merge/220331
>
> i lied when I wrote this comment
> --
> https://code.launchpad.net/~doanac/uci-engine/false-comment/+merge/220331
> Your team Canonical CI Engineering is requested to review the proposed
merge of lp:~doanac/uci-engine/false-comment into lp:uci-engine.
>
> === modified file 'ci-utils/ci_utils/ticket_states.py'
> --- ci-utils/ci_utils/ticket_states.py 2014-05-06 20:20:48 +0000
> +++ ci-utils/ci_utils/ticket_states.py 2014-05-20 21:54:00 +0000
> @@ -13,12 +13,6 @@
> # You should have received a copy of the GNU Affero General Public
License
> # along with this program. If not, see <http://www.gnu.org/licenses/>.
>
> -# WARNING !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
> -# these are constants used by the ticket-system API. As they are the API
> -# and values that live in a DB, you should *NOT* make changes unless you
> -# include a django-south migration and intend to break the API.
> -# WARNING !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
> -

I think the comment still stands, just remove the part about the DB. Making
changes could still greatly effect other pieces of the system and break
things.

> from lazr.enum import DBEnumeratedType, DBItem
>
>
>
>

On 05/20/2014 05:09 PM, Chris Johnston wrote:
>> -# WARNING !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
>> >-# these are constants used by the ticket-system API. As they are the API
>> >-# and values that live in a DB, you should*NOT* make changes unless you
>> >-# include a django-south migration and intend to break the API.
>> >-# WARNING !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
>> >-
> I think the comment still stands, just remove the part about the DB. Making
> changes could still greatly effect other pieces of the system and break
> things.

I think I'd rather just remove the whole thing. I don't think anyone
ever reads stuff like that anyway. And the comment would look a little
silly:

   WARNING: these are constants used by the ticket-system. be careful

I think the fact the file exists in ci-utils is a pretty good indicator
its important and used by >1 component.