Ubuntu CI Engine

Merge lp://qastaging/~doanac/uci-engine/feature-probe-lxc into lp://qastaging/uci-engine

  1. feature-probe-lxc
  2. Merge into trunk
Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 557
Merged at revision: 564
Proposed branch: lp://qastaging/~doanac/uci-engine/feature-probe-lxc
Merge into: lp://qastaging/uci-engine
Diff against target: 66 lines (+29/-9)
1 file modified
ci-utils/ci_utils/testing/features.py (+29/-9)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/feature-probe-lxc
Reviewer Review Type Date Requested Status
Vincent Ladeuil (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+222712@code.qastaging.launchpad.net

Commit message

feature probing: support juju-lxc

This allows our feature probing to account for juju-lxc deployments

Description of the change

This helps me to run the integration tests via juju-lxc

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:557
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/819/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/819/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:557
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/831/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/831/rebuild

review: Approve (continuous-integration)
Revision history for this message
Vincent Ladeuil (vila) wrote :

Full agreement.

One inline question.

And the $1e6 one: how are the integration tests running under lxc ? No failures ? Some failures ?

review: Approve
Revision history for this message
Andy Doan (doanac) wrote :

On 06/11/2014 11:49 AM, Vincent Ladeuil wrote:
> Review: Approve
>
> Full agreement.
>
> One inline question.
>
> And the $1e6 one: how are the integration tests running under lxc ? No failures ? Some failures ?

I'm still running individual tests. I haven't tried to test everything yet.

> Diff comments:
>
>> >=== modified file 'ci-utils/ci_utils/testing/features.py'

>> >@@ -12,14 +12,16 @@
>> >
>> > # You should have received a copy of the GNU Affero General Public License
>> > # along with this program. If not, see<http://www.gnu.org/licenses/>.
>> >-
>> >-from novaclient import exceptions as nova_exceptions
>> >-from novaclient.v1_1 import client as nova_client
>> > import os
>> > import subprocess
>> >+
>> > import swiftclient
>> >+import yaml
>> >+
>> >+from novaclient import exceptions as nova_exceptions
>> >+from novaclient.v1_1 import client as nova_client
> I'm always wondering what the kosher order is;) Can we write that somewhere ?
>
> I vaguely use: python ones, deps ones, project ones but the difference always sound a bit artificial and I wonder what the rationale is...

I'm not too pedantic about this. The main thing I like to see is
separation between standard python libs and stuff we depend on.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches