Ubuntu CI Engine

Merge lp://qastaging/~doanac/uci-engine/imgbuild-lock into lp://qastaging/uci-engine

imgbuild-lock
Merge into trunk

Proposed by Andy Doan on 2014-07-15

Status:	Merged
Approved by:	Andy Doan on 2014-07-17
Approved revision:	676
Merged at revision:	684
Proposed branch:	lp://qastaging/~doanac/uci-engine/imgbuild-lock
Merge into:	lp://qastaging/uci-engine
Prerequisite:	lp://qastaging/~doanac/uci-engine/rabbit-cron
Diff against target:	33 lines (+9/-0) 1 file modified image-builder/imagebuilder/cloud_image.py (+9/-0)
To merge this branch:	bzr merge lp://qastaging/~doanac/uci-engine/imgbuild-lock
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Paul Larson		2014-07-15	Approve on 2014-07-17
PS Jenkins bot (community)	continuous-integration		Approve on 2014-07-15
Review via email: mp+226913@code.qastaging.launchpad.net

Commit message

provide lock for cloud_image logic

This code was always intended to only allow one instance running
at a time. For the most part rabbit enforces this for us, but this
adds an extra layer of saftey

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-15:

PASSED: Continuous integration, rev:676
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1084/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1084/rebuild

review: Approve (continuous-integration)

Revision history for this message

Paul Larson (pwlars) wrote on 2014-07-17:

As long as we don't ever end up in a stale lock situation, I don't see any harm in this. I don't see any concern with that here though. +1

review: Approve

Revision history for this message

Andy Doan (doanac) wrote on 2014-07-17:

the good thing about flock is that as soon as the file is closed (ie - the
process dies) the flock gets released by the OS :)

On Thu, Jul 17, 2014 at 9:29 AM, Paul Larson <email address hidden>
wrote:

> Review: Approve
>
> As long as we don't ever end up in a stale lock situation, I don't see any
> harm in this. I don't see any concern with that here though. +1
> --
> https://code.launchpad.net/~doanac/uci-engine/imgbuild-lock/+merge/226913
> You are the owner of lp:~doanac/uci-engine/imgbuild-lock.
>