Ubuntu CI Engine

Merge lp://qastaging/~doanac/uci-engine/imgbuilder-integration-test into lp://qastaging/uci-engine

  1. imgbuilder-integration-test
  2. Merge into trunk
Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 682
Merged at revision: 687
Proposed branch: lp://qastaging/~doanac/uci-engine/imgbuilder-integration-test
Merge into: lp://qastaging/uci-engine
Prerequisite: lp://qastaging/~doanac/uci-engine/imgbuild-lock
Diff against target: 272 lines (+187/-0)
5 files modified
ci-utils/ci_utils/amqp_worker.py (+40/-0)
ci-utils/ci_utils/tests/test_amqp_worker.py (+10/-0)
image-builder/check_imagebuild.py (+118/-0)
image-builder/imagebuilder/run_worker.py (+17/-0)
juju-deployer/image-builder.yaml.tmpl (+2/-0)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/imgbuilder-integration-test
Reviewer Review Type Date Requested Status
Evan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+226915@code.qastaging.launchpad.net

Commit message

image-builder: add a long running integration test that builds an image

This also includes the logic to support running it via cron and reporting its results via our engine health page

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:679
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1083/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1083/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Evan (ev) wrote :

A risk I see with this approach is that it doesn't verify the image builder worker process, which through some great misfortune might be on an older code revno while this check is constantly pulling in whatever modules are on disk.

It's an edge case and I'm far more interested in having good production tests like this that evolve as we learn. Let's get this landed.

Just one problem discussed inline at:
182 + _delete_image(log, result)

review: Needs Fixing
Revision history for this message
Andy Doan (doanac) wrote :

i'll try and get the comments adressed tomorrow

Revision history for this message
Evan (ev) wrote :

On 16 July 2014 04:52, Andy Doan <email address hidden> wrote:
>> + results['last_run'] = time.time()
>
> i thought that opening the file in append mode would alter the mtime. I'll have to check to verify, that this kind of check wouldn't cause us to artificially bump the "last_run".

It would, you're right. Worth calling out to why we do it this way in a comment.

lp://qastaging/~doanac/uci-engine/imgbuilder-integration-test updated
680. By Andy Doan

back out the deploy.py change. that's supposed to be coming from
another branch

681. By Andy Doan

review comments

clarify some tricky stuff around the last-run-file

682. By Andy Doan

make check more exception safe

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:682
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1088/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1088/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andy Doan (doanac) wrote :

evan - this should have your requested changes now i think

Revision history for this message
Evan (ev) wrote :

Looks good. Thanks for the follow up!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches