Merge lp://qastaging/~doanac/uci-engine/lander-charm-helpers into lp://qastaging/uci-engine

Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 624
Merged at revision: 627
Proposed branch: lp://qastaging/~doanac/uci-engine/lander-charm-helpers
Merge into: lp://qastaging/uci-engine
Diff against target: 456 lines (+229/-88)
5 files modified
charms/precise/lander/Makefile (+3/-0)
charms/precise/lander/hooks/hooks.py (+83/-88)
charms/precise/lander/unit_tests/__init__.py (+14/-0)
charms/precise/lander/unit_tests/test_hooks.py (+128/-0)
testing/run_tests.py (+1/-0)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/lander-charm-helpers
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Evan (community) Approve
Review via email: mp+224715@code.qastaging.launchpad.net

Commit message

lander charm: make more charm-helper friendly

This makes this more charmhelper friendly and adds some testing.

Description of the change

lander charm: make more charm-helper friendly

This makes this more charmhelper friendly and adds some testing.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:624
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~doanac/uci-engine/lander-charm-helpers/+merge/224715/+edit-commit-message

http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/947/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/947/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Evan (ev) wrote :

A huge +1, with some small comments inline.

review: Approve
Revision history for this message
Andy Doan (doanac) wrote :

response inline. I say we just merge this. My next MP fixes one concern and we can put an asana task for the jinja stuff

Revision history for this message
Evan (ev) wrote :

+1. Comments inline for created Asana tasks, but I agree with everything you said. Let's deal with these other issues elsewhere.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:624
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/955/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/955/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches