Ubuntu CI Engine

Merge lp://qastaging/~doanac/uci-engine/lander-cleanups-3 into lp://qastaging/uci-engine

  1. lander-cleanups-3
  2. Merge into trunk
Proposed by Andy Doan
Status: Merged
Approved by: Francis Ginther
Approved revision: 440
Merged at revision: 448
Proposed branch: lp://qastaging/~doanac/uci-engine/lander-cleanups-3
Merge into: lp://qastaging/uci-engine
Prerequisite: lp://qastaging/~doanac/uci-engine/lander-cleanups-2
Diff against target: 371 lines (+47/-64)
9 files modified
charms/precise/lander-jenkins/templates/jobs/lander_branch_source_builder.xml (+3/-3)
charms/precise/lander-jenkins/templates/jobs/lander_image_builder.xml (+3/-3)
charms/precise/lander-jenkins/templates/jobs/lander_master.xml (+5/-15)
charms/precise/lander-jenkins/templates/jobs/lander_ppa_assigner.xml (+3/-3)
charms/precise/lander-jenkins/templates/jobs/lander_ppa_free.xml (+3/-3)
charms/precise/lander-jenkins/templates/jobs/lander_publisher.xml (+3/-3)
charms/precise/lander-jenkins/templates/jobs/lander_test_runner.xml (+3/-3)
lander/bin/lander_service_wrapper.py (+13/-16)
lander/lander/tests/test_service_wrapper.py (+11/-15)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/lander-cleanups-3
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Vincent Ladeuil (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+216242@code.qastaging.launchpad.net

Commit message

lander: use a single results file with the service-wrapper

The service-wrapper takes an input and output file and the
jenkins job does the work of combining these. This updates
the wrapper to produce the unified file.

Description of the change

lander: use a single results file with the service-wrapper

The service-wrapper takes an input and output file and the
jenkins job does the work of combining these. This updates
the wrapper to produce the unified file.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:440
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/512/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/512/rebuild

review: Approve (continuous-integration)
Revision history for this message
Vincent Ladeuil (vila) wrote :

The resulting code is clearer and simpler, I can hardly argue.

Trusting that you've tested that manually (I'd love that we had tests for that ;), +1

review: Approve
Revision history for this message
Andy Doan (doanac) wrote :

On 04/23/2014 11:24 AM, Vincent Ladeuil wrote:
> The resulting code is clearer and simpler, I can hardly argue.
>
> Trusting that you've tested that manually (I'd love that we had tests for that;), +1

yes - and once we get the lander-cleanups done, I'll be proposing
something that allows for more automated testing of this.

Revision history for this message
Francis Ginther (fginther) wrote :

Approve.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches