Ubuntu CI Engine

Merge lp://qastaging/~doanac/uci-engine/lander-flows into lp://qastaging/uci-engine

lander-flows
Merge into trunk

Proposed by Andy Doan on 2014-05-02

Status:	Merged
Approved by:	Francis Ginther on 2014-05-12
Approved revision:	463
Merged at revision:	478
Proposed branch:	lp://qastaging/~doanac/uci-engine/lander-flows
Merge into:	lp://qastaging/uci-engine
Diff against target:	667 lines (+182/-156) 4 files modified lander/bin/lander_process_ticket.py (+16/-28) lander/bin/lander_service_wrapper.py (+34/-47) lander/lander/tests/test_service_wrapper.py (+47/-81) lander/lander/workflow.py (+85/-0)
To merge this branch:	bzr merge lp://qastaging/~doanac/uci-engine/lander-flows
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Francis Ginther		2014-05-02	Approve on 2014-05-12
PS Jenkins bot (community)	continuous-integration		Approve on 2014-05-12
Review via email: mp+218150@code.qastaging.launchpad.net

Commit message

lander: introduce beginnings of a "workflow"

This moves us more towards being able to give the lander a
specific workflow for it to iterate through. For now its
hard-coded, but we could expand on this get the required workflow
of a ticket from the ticket-system.

This creates a results file / workflow that looks like:
{
  'ppa_assigner_url': ppa_url,
  'progress_trigger': 'lander-%d' % time.time(),
  'ticket_id': ticket_id,
  'ts_url': ts_url,
  'steps': [
    {'name': 'ppa_assigner'},
    {'name': 'bsbuilder'},
  ],
}

Description of the change

Here's a view of the file upon completion of a ticket:

https://region-a.geo-1.objects.hpcloudsvc.com/v1/11630049285977/ticket-1/ticket-1_results.json

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-02:

PASSED: Continuous integration, rev:462
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/579/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/579/rebuild

review: Approve (continuous-integration)

Revision history for this message

Francis Ginther (fginther) wrote on 2014-05-09:

Looks good. The only thing I noticed was that it's possible to shorten this up:
280 + results = handler(amqp_config, workflow, workflow.ticket_api())

As workflow.ticket_id is part of workflow, there is no need to pass both.

I don't see this as a reason to block progress here, so I'll approve if you want to refactor this later.

review: Needs Fixing

Revision history for this message

Andy Doan (doanac) wrote on 2014-05-12:

On 05/09/2014 02:03 PM, Francis Ginther wrote:
> I don't see this as a reason to block progress here, so I'll approve if you want to refactor this later.

i'll fix today. its easy enough and my original rationale for doing that
way (to make the diff smaller) didn't pan out as i hoped anyway.

lp://qastaging/~doanac/uci-engine/lander-flows updated on 2014-05-12