Merge lp://qastaging/~doanac/uci-engine/lander-no-relations into lp://qastaging/uci-engine

Proposed by Andy Doan
Status: Merged
Approved by: Francis Ginther
Approved revision: 617
Merged at revision: 617
Proposed branch: lp://qastaging/~doanac/uci-engine/lander-no-relations
Merge into: lp://qastaging/uci-engine
Diff against target: 55 lines (+23/-0)
3 files modified
lander/bin/json_status_cgi.py (+17/-0)
lander/lander/run_worker.py (+2/-0)
lander/lander/tests/test_run_worker.py (+4/-0)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/lander-no-relations
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Francis Ginther Approve
Evan (community) Approve
Review via email: mp+224471@code.qastaging.launchpad.net

Commit message

lander: don't crash when no juju-relations exist

We are seeing something in production where the lander is starting
before the juju-relations directory exist. I'm actually surprised
this code ever worked well. This does a check so that we'll wait
properly.

I've also added a small engine-health-check so the exact error will be
visible in our webui.

To post a comment you must log in.
Revision history for this message
Evan (ev) wrote :

Looks good.

review: Approve
Revision history for this message
Francis Ginther (fginther) wrote :

I hot patched my lander to add the lander/bin/json_status_cgi.py and all looked good.

Approve.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:617
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/934/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/934/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches