Ubuntu CI Engine

Merge lp://qastaging/~doanac/uci-engine/lander-ts-rabbit into lp://qastaging/uci-engine

lander-ts-rabbit
Merge into trunk

Proposed by Andy Doan on 2014-05-16

Status:	Merged
Approved by:	Andy Doan on 2014-05-20
Approved revision:	491
Merged at revision:	496
Proposed branch:	lp://qastaging/~doanac/uci-engine/lander-ts-rabbit
Merge into:	lp://qastaging/uci-engine
Prerequisite:	lp://qastaging/~doanac/uci-engine/ticket-system-amqp
Diff against target:	450 lines (+80/-184) 11 files modified ci-utils/ci_utils/amqp_utils.py (+1/-0) docs/components/ticket-system.rst (+0/-9) juju-deployer/ticket-system.yaml.tmpl (+1/-1) lander/lander/run_worker.py (+30/-24) lander/lander/tests/test_run_worker.py (+15/-37) ticket_system/ticket/api.py (+0/-16) ticket_system/ticket/models.py (+16/-0) ticket_system/ticket/tests/test_full_read_api.py (+0/-94) ticket_system/ticket/tests/test_models.py (+10/-0) ticket_system/ticket/tests/test_read_api.py (+6/-1) ticket_system/ticket_system/urls.py (+1/-2)
To merge this branch:	bzr merge lp://qastaging/~doanac/uci-engine/lander-ts-rabbit
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Celso Providelo (community)		2014-05-16	Approve on 2014-05-20
PS Jenkins bot (community)	continuous-integration		Approve on 2014-05-16
Review via email: mp+219900@code.qastaging.launchpad.net

Commit message

lander/ticket-system: convert to rabbit

This changes the lander/ticket relationship so that the ticket
system simply sends amqp messages that the lander can handle. This
is the first step in allowing us to scale to multiple landers.

Description of the change

This moves us from having the lander poll the ticket-system to having the ticket system push to a rabbit queue that the lander is subscribed to.

I wanted to do this later in the cycle, but I'm about to change some ticket-workflow code and it really made not point basing that work on something that was about to change.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-16:

PASSED: Continuous integration, rev:491
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/649/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/649/rebuild

review: Approve (continuous-integration)

Revision history for this message

Celso Providelo (cprov) wrote on 2014-05-19:

Andy,

As far as I can tell, this was the only use case for exposing TS REST API internally. With that gone all the *internal* component interactions will happen via queues and the TS API will be only used via Web UI redirect from WebUI itself and the CLI.

Restricting TS API clients will make things easier for adding authentication, but blocks Gatekeeper integration, since it will be the only internal component in need to poke TS.

I think restrict TS API for authenticated access is the way to go, we should just find a solution for GK integration.

Revision history for this message

Andy Doan (doanac) wrote on 2014-05-19:

Celso - to summarize here as we discussed earlier:

We'll still need interal API access to the ticket-system. As we move to authenticated API's we'll need to ensure we deploy a token to the lander and gatekeeper so they can interact with the ticket-system

Revision history for this message

Celso Providelo (cprov) wrote on 2014-05-19:

Andy,

Thanks, we have a plan to follow.

[]

On Mon, May 19, 2014 at 3:34 PM, Andy Doan <email address hidden> wrote:
> Celso - to summarize here as we discussed earlier:
>
> We'll still need interal API access to the ticket-system. As we move to authenticated API's we'll need to ensure we deploy a token to the lander and gatekeeper so they can interact with the ticket-system
> --
> https://code.launchpad.net/~doanac/uci-engine/lander-ts-rabbit/+merge/219900
> Your team Canonical CI Engineering is requested to review the proposed merge of lp:~doanac/uci-engine/lander-ts-rabbit into lp:uci-engine.