Ubuntu CI Engine

Merge lp://qastaging/~doanac/uci-engine/ppa-health-improvement into lp://qastaging/uci-engine

  1. ppa-health-improvement
  2. Merge into trunk
Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 540
Merged at revision: 549
Proposed branch: lp://qastaging/~doanac/uci-engine/ppa-health-improvement
Merge into: lp://qastaging/uci-engine
Diff against target: 48 lines (+17/-7)
2 files modified
ppa-assigner/ppa_assigner/api.py (+7/-1)
ppa-assigner/ppa_assigner/tests.py (+10/-6)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/ppa-health-improvement
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+222234@code.qastaging.launchpad.net

Commit message

ppa-assigner health: improve reporting

show the ppa owner so users know where the ppa's are.

also don't show "private ppas only" as a pass/fail. its really just
useful debug info that doesn't reall reflect a "bad" state

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:539
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/785/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/785/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Celso Providelo (cprov) wrote :

As discussed on IRC, it would be nice if we can have, at least, a very basic django-view test checking the contents of the new json_status page.

review: Needs Fixing
lp://qastaging/~doanac/uci-engine/ppa-health-improvement updated
540. By Andy Doan

oops - include/update testing

Revision history for this message
Andy Doan (doanac) wrote :

cprov - should be addressed now.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:540
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/787/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/787/rebuild

review: Approve (continuous-integration)
Revision history for this message
Celso Providelo (cprov) wrote :

Looks great! Thank you for adding tests.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches