Ubuntu CI Engine

Merge lp://qastaging/~doanac/uci-engine/restish-charmhelpers into lp://qastaging/uci-engine

  1. restish-charmhelpers
  2. Merge into trunk
Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 558
Merged at revision: 559
Proposed branch: lp://qastaging/~doanac/uci-engine/restish-charmhelpers
Merge into: lp://qastaging/uci-engine
Diff against target: 413 lines (+143/-125)
2 files modified
charms/precise/restish/hooks/hooks.py (+75/-118)
charms/precise/restish/unit_tests/test_hooks.py (+68/-7)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/restish-charmhelpers
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Celso Providelo (community) Approve
Review via email: mp+222727@code.qastaging.launchpad.net

Commit message

restish-charm: complete transition to charmhelpers

This moves the restish charm completely to charm helpers and
adds a little more unit testing

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:557
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/820/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/820/rebuild

review: Approve (continuous-integration)
Revision history for this message
Celso Providelo (cprov) wrote :

Super! Thanks for working on this.

Only a minor hint for consolidating hooks and you can land it!

review: Approve
lp://qastaging/~doanac/uci-engine/restish-charmhelpers updated
558. By Andy Doan

mp fixes from cprov

consolidate our hook functions now that we use hooks

also - noticed a bug with json status hook and added a test case
along with the fix

Revision history for this message
Andy Doan (doanac) wrote :

fixed in 558

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:558
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/822/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/822/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches