Ubuntu CI Engine

Merge lp://qastaging/~doanac/uci-engine/restish-cron into lp://qastaging/uci-engine

  1. restish-cron
  2. Merge into trunk
Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 617
Merged at revision: 620
Proposed branch: lp://qastaging/~doanac/uci-engine/restish-cron
Merge into: lp://qastaging/uci-engine
Diff against target: 96 lines (+64/-1)
3 files modified
charms/precise/restish/config.yaml (+9/-0)
charms/precise/restish/hooks/hooks.py (+22/-1)
charms/precise/restish/unit_tests/test_hooks.py (+33/-0)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/restish-cron
Reviewer Review Type Date Requested Status
Paul Larson Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+224484@code.qastaging.launchpad.net

Commit message

restish charm: provide a way to run cron tasks

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:617
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/937/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/937/rebuild

review: Approve (continuous-integration)
Revision history for this message
Paul Larson (pwlars) wrote :

This seems useful, but is there a cron entry in particular that you plan to add with this? would be nice to have that in the yaml file if so. Otherwise I assume that's coming in a future revision. Also, I'm not sure there's a really "nice" way to do this other than preserving the order of the commands and periods to run them, but would it be useful to have it handle more than one cron entry? Otherwise, +1

review: Approve
Revision history for this message
Andy Doan (doanac) wrote :

On 06/25/2014 01:28 PM, Paul Larson wrote:
> This seems useful, but is there a cron entry in particular that you plan to add with this? would be nice to have that in the yaml file if so. Otherwise I assume that's coming in a future revision. Also, I'm not sure there's a really "nice" way to do this other than preserving the order of the commands and periods to run them, but would it be useful to have it handle more than one cron entry? Otherwise, +1

Its going to be landing in another branch max and thomi are working on.
I wanted to keep them as close to trunk as possible though.

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

LGTM, thanks.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches