Merge lp://qastaging/~doanac/uci-engine/restish-db-migrate into lp://qastaging/uci-engine

Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 575
Merged at revision: 587
Proposed branch: lp://qastaging/~doanac/uci-engine/restish-db-migrate
Merge into: lp://qastaging/uci-engine
Diff against target: 72 lines (+29/-0)
3 files modified
charms/precise/restish/config.yaml (+4/-0)
charms/precise/restish/hooks/hooks.py (+9/-0)
charms/precise/restish/unit_tests/test_hooks.py (+16/-0)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/restish-db-migrate
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+222994@code.qastaging.launchpad.net

Commit message

restish charm: support db migrations

This is a super simplistic way, but should work. You simply add something
like:

 db_migration_cmd: ./nf-data-collector/migrate.sh

to your deployer yaml and the script will get run when the pgsql relation
changes or the charm is upgraded

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:574
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/852/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/852/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:574
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/853/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/853/rebuild

review: Approve (continuous-integration)
Revision history for this message
Celso Providelo (cprov) wrote :

It's looks great, thanks for working on it.

As discussed on IRC, the configuration option description should be clearer about supporting execution paths relative to the deployed tree/dir. Otherwise users will be always confused.

review: Approve
575. By Andy Doan

document relative path of migration command as per cprov

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches