Ubuntu CI Engine

Merge lp://qastaging/~doanac/uci-engine/restish-logging into lp://qastaging/uci-engine

  1. restish-logging
  2. Merge into trunk
Proposed by Andy Doan
Status: Rejected
Rejected by: Andy Doan
Proposed branch: lp://qastaging/~doanac/uci-engine/restish-logging
Merge into: lp://qastaging/uci-engine
Diff against target: 162 lines (+41/-32)
3 files modified
charms/precise/restish/config.yaml (+4/-0)
charms/precise/restish/hooks/hooks.py (+28/-21)
charms/precise/restish/unit_tests/test_hooks.py (+9/-11)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/restish-logging
Reviewer Review Type Date Requested Status
Andy Doan (community) Disapprove
PS Jenkins bot (community) continuous-integration Needs Fixing
Chris Johnston (community) Needs Information
Review via email: mp+222818@code.qastaging.launchpad.net

Commit message

restish-charm: use a "code" directory for deployment

Moves our deployed code into a directory under the charm as per
i/s guidelines

To post a comment you must log in.
Revision history for this message
Chris Johnston (cjohnston) :
review: Needs Information
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:560
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/832/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/832/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~doanac/uci-engine/restish-logging updated
561. By Andy Doan

[r=Francis Ginther, PS Jenkins bot] ticket-system: add concept of "reviews"

This allows us to attach reviews to a ticket. The reviews can be
mapped to workflow steps so that the lander can be paused at the
point a review is needed. Once all reviews are completed, the
ticket-system will resume the ticket by notifying the lander. from Andy Doan

Revision history for this message
Andy Doan (doanac) wrote :

responses inline

Revision history for this message
Chris Johnston (cjohnston) :
Revision history for this message
Andy Doan (doanac) wrote :

On 06/11/2014 11:15 AM, Chris Johnston wrote:
>> + expected = {
>> >+ 'working_dir': '/srv/restish/development',
> This isn't actually configurable is it?
>

its derived by the service name we use with juju/juju-deployer. So in my
environment its deployed as:

  /srv/ci_airline_gatekeeper_restish

to make that something else, you change the service names in the yaml
for juju-deployer.

lp://qastaging/~doanac/uci-engine/restish-logging updated
562. By Vincent Ladeuil

[r=Andy Doan, PS Jenkins bot] Provides the 'series' parameter to the test runner 1328193 from Vincent Ladeuil

563. By Vincent Ladeuil

[r=PS Jenkins bot, Evan Dandrea] Skip charm and integration tests when check_environment complains about missing env vars 1319703 from Vincent Ladeuil

564. By Andy Doan

[r=Vincent Ladeuil, PS Jenkins bot] feature probing: support juju-lxc

This allows our feature probing to account for juju-lxc deployments from Andy Doan

Revision history for this message
Chris Johnston (cjohnston) wrote :

That still wont add the service name at the end of the path.

lp://qastaging/~doanac/uci-engine/restish-logging updated
565. By Chris Johnston

[r=Francis Ginther] Update apache charm revno to include apt-get update fix from Chris Johnston

566. By Chris Johnston

[r=PS Jenkins bot, Celso Providelo] Update rabbitmq-server revision number to fix apt-get install problem 1328864 from Chris Johnston

567. By Celso Providelo

[r=Andy Doan, PS Jenkins bot] Refactoring 'get_image' CLI action to download images using tempurls provided by Gatekeeper. from Celso Providelo

568. By Celso Providelo

[r=Andy Doan, PS Jenkins bot, Vincent Ladeuil] Silencing the virtualenv installation in the integration tests. from Celso Providelo

569. By Ursula Junque

[r=PS Jenkins bot, Celso Providelo] Switching lander to call publisher worker and run ppa_sync.copy directly, instead of running the ppa_sync script. from Ursula Junque

570. By Ursula Junque

[r=PS Jenkins bot, Celso Providelo] Switching lander to call publisher worker and run ppa_sync.copy directly, instead of running the ppa_sync script. from Ursula Junque

Revision history for this message
Andy Doan (doanac) wrote :

On 06/11/2014 02:00 PM, Chris Johnston wrote:
> That still wont add the service name at the end of the path.

could you not change install_root from /srv to
/srv/ci-engine.ubuntu.com ?

Seems the way you are asking means we could never deploy 2 units of
something to a single host. Also - just for clarity, i assume if we
*must* do what you are saying, then we have to have a config value for
this? Also - this service isn't ci-engine.ubuntu.com its really more
ci-gatekeeper.ubuntu.com (or something that isn't even a DNS name)? I'm
really confused what we are trying to solve as I think about this more.

Revision history for this message
Chris Johnston (cjohnston) wrote :

"Policy:

You must:

...
Create a /srv/${external-service-name}/${instance-type}/${service-name} directory for the code itself, and /srv/${external-service-name}/{${instance-type}-logs,scripts,etc,var} as needed.
..."

The entire project is a single service.. It is all the CI Engine AIUI.. Every component should be /srv/ci-engine.ubuntu.com/<instance-type>/<service-name>...

So in this case I guess it would be /srv/ci-engine.ubuntu.com/development/gatekeeper

Revision history for this message
Chris Johnston (cjohnston) wrote :

To clarify...

The entire project is a single *external* service...

Revision history for this message
Andy Doan (doanac) wrote :

Chris - This isn't aimed at you, as I realize you are just the messenger.

However, I'm not going to spend another 3 hours refactoring and testing this stuff. I'm self-naking, and moving on to working on tangible product features. We are despartely behind schedule and I've accomplished nothing this week that gets us closer to our goals.

review: Disapprove

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches