Merge lp://qastaging/~doanac/uci-engine/restish-ppa into lp://qastaging/uci-engine

Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 669
Merged at revision: 668
Proposed branch: lp://qastaging/~doanac/uci-engine/restish-ppa
Merge into: lp://qastaging/uci-engine
Prerequisite: lp://qastaging/~doanac/uci-engine/restish-django
Diff against target: 135 lines (+35/-36)
3 files modified
juju-deployer/ppa-assigner.yaml.tmpl (+10/-12)
juju-deployer/production-only.yaml (+5/-5)
ppa-assigner/ppa_assigner/settings.py (+20/-19)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/restish-ppa
Reviewer Review Type Date Requested Status
Evan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+226406@code.qastaging.launchpad.net

Commit message

ppa-assigner: convert to restish charm

This also fixes some upstart related problems I found with the ppa-cleaner not always starting/stopping

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:669
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1051/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1051/rebuild

review: Approve (continuous-integration)
Revision history for this message
Evan (ev) wrote :

This looks entirely reasonable. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches