Ubuntu CI Engine

Merge lp://qastaging/~doanac/uci-engine/restish-pyramid into lp://qastaging/uci-engine

  1. restish-pyramid
  2. Merge into trunk
Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 573
Merged at revision: 573
Proposed branch: lp://qastaging/~doanac/uci-engine/restish-pyramid
Merge into: lp://qastaging/uci-engine
Prerequisite: lp://qastaging/~doanac/uci-engine/restish-pgsql
Diff against target: 103 lines (+34/-7)
4 files modified
charms/precise/restish/config.yaml (+4/-4)
charms/precise/restish/hooks/hooks.py (+9/-1)
charms/precise/restish/metadata.yaml (+2/-2)
charms/precise/restish/unit_tests/test_hooks.py (+19/-0)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/restish-pyramid
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Celso Providelo (community) Approve
Review via email: mp+222979@code.qastaging.launchpad.net

Commit message

restish charm: allow deploying the python-pyramid framework

To post a comment you must log in.
Revision history for this message
Celso Providelo (cprov) wrote :

Nice, it's becoming more like a "python-wsgi" charm.

Can we have a quick test for the framework implications ?

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:572
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/845/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/845/rebuild

review: Approve (continuous-integration)
lp://qastaging/~doanac/uci-engine/restish-pyramid updated
573. By Andy Doan

cprov review: add a test for the framework option

Revision history for this message
Andy Doan (doanac) wrote :

> Nice, it's becoming more like a "python-wsgi" charm.
>
> Can we have a quick test for the framework implications ?

yep. just added it. Can you also take a look at the pre-req branch for this so we can land both of these changes?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:573
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/848/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/848/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:573
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/850/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/850/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches