Ubuntu CI Engine

Merge lp://qastaging/~doanac/uci-engine/restish-ticketsystem into lp://qastaging/uci-engine

  1. restish-ticketsystem
  2. Merge into trunk
Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 671
Merged at revision: 670
Proposed branch: lp://qastaging/~doanac/uci-engine/restish-ticketsystem
Merge into: lp://qastaging/uci-engine
Diff against target: 146 lines (+50/-43)
2 files modified
juju-deployer/ticket-system.yaml.tmpl (+12/-15)
ticket_system/ticket_system/settings.py (+38/-28)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/restish-ticketsystem
Reviewer Review Type Date Requested Status
Evan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+226494@code.qastaging.launchpad.net

Commit message

ticket-system: convert to restish charm

Description of the change

the last of the django components using the django charm!

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:670
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1059/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1059/rebuild

review: Approve (continuous-integration)
Revision history for this message
Evan (ev) wrote :

Extraordinarily minor nit. Don't let it block landing this though. +1

review: Approve
Revision history for this message
Andy Doan (doanac) wrote :

On 07/11/2014 12:14 PM, Evan Dandrea wrote:
>> +# files created by restish juju charm
>> >+pgsql = os.path.join(BASEDIR, '../../../pgsql.json')
>> >+if os.path.exists(pgsql):
>> >+ print('pgsql settings from %s' % pgsql)
>> >+ pgsql = json.load(open(pgsql))
> You're leaking file descriptors. Not terribly important, given the lifetime of the application, but it hurts my eyes.
>

its actually safe in CPython, but that's not really a good justification :)

I think I'll fix it now before getting it merged.

lp://qastaging/~doanac/uci-engine/restish-ticketsystem updated
671. By Andy Doan

use "open" more responsibly

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches