Ubuntu CI Engine

Merge lp://qastaging/~doanac/uci-engine/restish-webui into lp://qastaging/uci-engine

  1. restish-webui
  2. Merge into trunk
Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 670
Merged at revision: 671
Proposed branch: lp://qastaging/~doanac/uci-engine/restish-webui
Merge into: lp://qastaging/uci-engine
Prerequisite: lp://qastaging/~doanac/uci-engine/restish-django
Diff against target: 73 lines (+18/-24)
2 files modified
juju-deployer/webui.yaml.tmpl (+12/-13)
webui/webui/settings.py (+6/-11)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/restish-webui
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Celso Providelo (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+226405@code.qastaging.launchpad.net

Commit message

webui: convert to use restish charm

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:669
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1052/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1052/rebuild

review: Approve (continuous-integration)
lp://qastaging/~doanac/uci-engine/restish-webui updated
670. By Andy Doan

use open smarter

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:670
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1061/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1061/rebuild

review: Approve (continuous-integration)
Revision history for this message
Celso Providelo (cprov) wrote :

Nice one! Looking forward to see your new MP renaming "restish" to something more coherent with its use (wsgi-app).

Who would have thought this charm, once removed from our tree, would have become part of the ci-airline core (along with rabbit-worker, also a local charm) ...

review: Approve
Revision history for this message
Andy Doan (doanac) wrote :

On 07/11/2014 02:09 PM, Celso Providelo wrote:
> Who would have thought this charm, once removed from our tree, would have become part of the ci-airline core

I totally forgot about that! So funny.

Revision history for this message
Francis Ginther (fginther) wrote :

Looks good, confirmed deploying of the webui with juju local and could access it. As discussed in IRC, the ALLOWED_HOSTS print doesn't go to the log files under /srv/$service/logs/, but that can be followed up later.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches