Ubuntu CI Engine

Merge lp://qastaging/~doanac/uci-engine/runner-health into lp://qastaging/uci-engine

  1. runner-health
  2. Merge into trunk
Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 658
Merged at revision: 659
Proposed branch: lp://qastaging/~doanac/uci-engine/runner-health
Merge into: lp://qastaging/uci-engine
Diff against target: 15 lines (+0/-5)
1 file modified
test_runner/tstrun/run_worker.py (+0/-5)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/runner-health
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+226172@code.qastaging.launchpad.net

Commit message

test-runner: use default worker health check

  I wrote this to also check the health of glance. However, I noticed in
production/hpcloud that we don't have the glance client installed:

 ImportError: No module named glanceclient

So this code path doesn't need testing

Description of the change

The test-runner health check is broken in production and I also now see it in hpcloud. Things were working for me via LXC because I had a package installed in my base image.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:658
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1032/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1032/rebuild

review: Approve (continuous-integration)
Revision history for this message
Celso Providelo (cprov) wrote :

Andy,

Thanks for removing the misleading test. TR doesn't need to create images, instead it needs access to find images & flavors via novaclient (see testbed.py).

The current change is good to be landed, but we should work for adding a novaclient health_check.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches