Merge lp://qastaging/~doanac/uci-engine/runner-refactor into lp://qastaging/uci-engine
| Status: | Rejected |
|---|---|
| Rejected by: | Vincent Ladeuil |
| Proposed branch: | lp://qastaging/~doanac/uci-engine/runner-refactor |
| Merge into: | lp://qastaging/uci-engine |
| Diff against target: |
442 lines (+213/-135) 4 files modified
test_runner/tstrun/run_worker.py (+13/-134) test_runner/tstrun/testbed.py (+137/-1) test_runner/tstrun/tests/test_testbed.py (+31/-0) test_runner/tstrun/tests/test_worker.py (+32/-0) |
| To merge this branch: | bzr merge lp://qastaging/~doanac/uci-engine/runner-refactor |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Vincent Ladeuil (community) | Disapprove | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
test-runner: simplify run-worker code
The handle_request function was growing too large to debug. It also
was written in a way that made it hard to test with a simple CLI like
we have for the image-builder.
This refactors things so that its easier to test the actual runner w/o
needing anything from rabbit.
Description of the change
I want to get something like the image-builder's cloud_image.py script that lets you build an image without having to worry about amqp. This refactors some logic in way to make things easier to isolate and test.
The end result gives you the ability to run something like (from home or in the cloud):
./run-python ./test_
| PS Jenkins bot (ps-jenkins) wrote | # |
| Vincent Ladeuil (vila) wrote | # |
Unmerged revisions
- 665. By Andy Doan
-
test-runner: simplify run-worker code
The handle_request function was growing too large to debug. It also
was written in a way that made it hard to test with a simple CLI like
we have for the image-builder.This refactors things so that its easier to test the actual runner w/o
needing anything from rabbit.
PASSED: Continuous integration, rev:665
http://
Executed test runs:
Click here to trigger a rebuild:
http://