Merge lp://qastaging/~doanac/uci-engine/ts-pause-continue into lp://qastaging/uci-engine

Proposed by Andy Doan
Status: Merged
Approved by: Francis Ginther
Approved revision: 507
Merged at revision: 543
Proposed branch: lp://qastaging/~doanac/uci-engine/ts-pause-continue
Merge into: lp://qastaging/uci-engine
Prerequisite: lp://qastaging/~doanac/uci-engine/db-workflow
Diff against target: 308 lines (+139/-19)
8 files modified
ci-utils/ci_utils/ticket_states.py (+2/-0)
lander/bin/lander_process_ticket.py (+29/-2)
lander/lander/run_worker.py (+28/-9)
lander/lander/tests/test_process_ticket.py (+52/-0)
lander/lander/tests/test_run_worker.py (+10/-0)
lander/lander/ticket_api.py (+2/-2)
ticket_system/ticket/models.py (+8/-5)
ticket_system/ticket/tests/test_models.py (+8/-1)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/ts-pause-continue
Reviewer Review Type Date Requested Status
Francis Ginther Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+220713@code.qastaging.launchpad.net

Commit message

lander/ticket-system: introduce concept of pause/continue

now that the lander can "resume", we'll add the notion of a ticket
that can be paused and then continued. By default this won't be
enabled. However, if you have a ticket created with a workflow that
has a step like like:

 {'name': 'bsbuilder', 'pause':{}}

Then the lander will see a ticket has a pause step that hasn't been
handled, update the ticket-system and exit. Later you can mark
the ticket to "CONTINUE" from something like the django admin panel.
This will send a message back to the lander to resume work

Description of the change

This adds ability to pause/continue tickets by create a specific type of ticket-workflow.

NOTE: the diff in ticket_states.py might seem confusing:

251 - def fail_ticket(self):
252 + def pause_ticket(self):

Turns out fail_ticket was unused and incorrect code. So I removed it and added the new pause_ticket method.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:505
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/681/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/681/rebuild

review: Needs Fixing (continuous-integration)
506. By Andy Doan

merge with the db-workflow branch to pick up broken test fix

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:506
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/760/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/760/rebuild

review: Approve (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Just one nit to split test_handle_lander() into two test cases, otherwise this looks good.

review: Needs Fixing
507. By Andy Doan

split up the unit tests as per fginther

Revision history for this message
Andy Doan (doanac) wrote :

On 06/05/2014 01:19 PM, Francis Ginther wrote:
> Just one nit to split test_handle_lander() into two test cases, otherwise this looks good.

good point. that should be fixed in revno 507 now.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:507
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/790/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/790/rebuild

review: Approve (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

> On 06/05/2014 01:19 PM, Francis Ginther wrote:
> > Just one nit to split test_handle_lander() into two test cases, otherwise
> this looks good.
>
> good point. that should be fixed in revno 507 now.

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches