Ubuntu CI Engine

Merge lp://qastaging/~doanac/uci-engine/ts-reviews into lp://qastaging/uci-engine

ts-reviews
Merge into trunk

Proposed by Andy Doan on 2014-05-22

Status:	Merged
Approved by:	Francis Ginther on 2014-06-11
Approved revision:	510
Merged at revision:	561
Proposed branch:	lp://qastaging/~doanac/uci-engine/ts-reviews
Merge into:	lp://qastaging/uci-engine
Prerequisite:	lp://qastaging/~doanac/uci-engine/ts-pause-continue
Diff against target:	299 lines (+163/-3) 7 files modified ci-utils/ci_utils/ticket_states.py (+10/-0) ticket_system/ticket/api.py (+15/-2) ticket_system/ticket/migrations/0002_uce0.py (+21/-0) ticket_system/ticket/models.py (+33/-1) ticket_system/ticket/tests/test_models.py (+40/-0) ticket_system/ticket/tests/test_write_api.py (+42/-0) ticket_system/ticket_system/urls.py (+2/-0)
To merge this branch:	bzr merge lp://qastaging/~doanac/uci-engine/ts-reviews
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Francis Ginther		2014-05-22	Approve on 2014-06-11
PS Jenkins bot (community)	continuous-integration		Approve on 2014-06-06
Review via email: mp+220715@code.qastaging.launchpad.net

Commit message

ticket-system: add concept of "reviews"

This allows us to attach reviews to a ticket. The reviews can be
mapped to workflow steps so that the lander can be paused at the
point a review is needed. Once all reviews are completed, the
ticket-system will resume the ticket by notifying the lander.

Description of the change

Adds the notion of a Review that can be attached to a ticket and integrate with the pause/continue support between the lander and ticket-system.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-22:

PASSED: Continuous integration, rev:506
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/680/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/680/rebuild

review: Approve (continuous-integration)

Revision history for this message

Francis Ginther (fginther) wrote on 2014-06-05:

I have some inline comments/questions. As we get a better understanding on reviews, workflows, etc. lets put together some documentation on how these are intended to be used, but not now.

review: Needs Information

Revision history for this message

Andy Doan (doanac) wrote on 2014-06-05:

responded to inline comments. and as a general comment - i agree, this workflow logic is becoming somewhat powerful, we'll need to find a concise way to explain it to people.

lp://qastaging/~doanac/uci-engine/ts-reviews updated on 2014-06-05

507. By Andy Doan on 2014-06-05

relocate workflow mapping to ticket-states

as per fginther. makes good sense

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-05:

FAILED: Continuous integration, rev:507
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/791/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/791/rebuild