Merge lp://qastaging/~doanac/uci-engine/ts-status-api-fix into lp://qastaging/uci-engine

Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 479
Merged at revision: 503
Proposed branch: lp://qastaging/~doanac/uci-engine/ts-status-api-fix
Merge into: lp://qastaging/uci-engine
Diff against target: 100 lines (+48/-3)
3 files modified
ticket_system/ticket/api.py (+28/-3)
ticket_system/ticket/models.py (+6/-0)
ticket_system/ticket/tests/test_write_api.py (+14/-0)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/ts-status-api-fix
Reviewer Review Type Date Requested Status
Francis Ginther Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+219253@code.qastaging.launchpad.net

Commit message

ticket-system: allow updating of just status or workflow-step

This fixes a bug and annoyance in the ticket system.

bug - you can't just update the status or workflow-step. They have
to both be provided

annoyance - we return status and workflow step back as words like
"in progress", but our write-api requires the inputs to be numerical.

This fixes both issues so that you can now just update a ticket's status
to something like 'failed'.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:478
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/622/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/622/rebuild

review: Needs Fixing (continuous-integration)
479. By Andy Doan

oops - used a ticket-status that doesn't yet exist in trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:479
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/633/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/633/rebuild

review: Approve (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

I can foresee us applying the same logic to SubTicketTranslatedResource, but we can do that when the time comes.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches