Ubuntu CI Engine

Merge lp://qastaging/~doanac/uci-engine/worker-health-glance-swift into lp://qastaging/uci-engine

  1. worker-health-glance-swift
  2. Merge into trunk
Proposed by Andy Doan
Status: Merged
Merged at revision: 633
Proposed branch: lp://qastaging/~doanac/uci-engine/worker-health-glance-swift
Merge into: lp://qastaging/uci-engine
Prerequisite: lp://qastaging/~doanac/uci-engine/worker-health
Diff against target: 112 lines (+33/-0)
6 files modified
ci-utils/ci_utils/amqp_worker.py (+1/-0)
ci-utils/ci_utils/data_store.py (+2/-0)
ci-utils/ci_utils/image_store/__init__.py (+2/-0)
ci-utils/ci_utils/json_status.py (+18/-0)
image-builder/imagebuilder/run_worker.py (+5/-0)
test_runner/tstrun/run_worker.py (+5/-0)
To merge this branch: bzr merge lp://qastaging/~doanac/uci-engine/worker-health-glance-swift
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+225068@code.qastaging.launchpad.net

Commit message

rabbit workers: add ability to check swift/glance

This allows a worker to check its connections to swift and/or glance. Since
all workers need swift, that's been added to the base class.

I happened to notice the exception we throw isn't that great in the
image_store and data_store, so I've added logging to where we can
look up more details in the event something is failing.

Description of the change

helps close out: https://app.asana.com/0/8312550429062/13431896743180

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:630
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/971/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/971/rebuild

review: Approve (continuous-integration)
Revision history for this message
Celso Providelo (cprov) wrote :

Looks good, but I'm still concerned it will be doing quite a lot of work when the public status-page gets accessed. Would it be possible to cache some information in the webui for wider audience and have a limited-access view (admins, nagios, etc) accessing fresh data ?

Additionally I have 2 diff comments about the actual checks for your consideration.

If you think the load derived from the status page can be addressed later (when we have authentication ) and even if the checks offer only a good approximation of a IS_WORKING status for swift and glance, we are good, r=me.

review: Approve
Revision history for this message
Andy Doan (doanac) wrote :

We could put some could add some caching logic to the "run_server" function in:

 https://code.launchpad.net/~doanac/uci-engine/worker-health/+merge/224890

hold data for 10 seconds, unless you get a "refresh=True" parameter which could invalidate the cache. Sound reasonable?

Revision history for this message
Andy Doan (doanac) wrote :

cprov - should be fixed now (image creation that is). Care to re-view the latest change? I think the caching stuff needs to happen (especially now that I create an image). I think that should go in the pre-req MP for this though.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches