intltool

Merge lp://qastaging/~dobey/intltool/regex-fix into lp://qastaging/intltool

  1. regex-fix
  2. Merge into trunk
Proposed by dobey
Status: Needs review
Proposed branch: lp://qastaging/~dobey/intltool/regex-fix
Merge into: lp://qastaging/intltool
Diff against target: 44 lines (+10/-10)
1 file modified
intltool-update.in (+10/-10)
To merge this branch: bzr merge lp://qastaging/~dobey/intltool/regex-fix
Reviewer Review Type Date Requested Status
intltool Developers Pending
Review via email: mp+283202@code.qastaging.launchpad.net

Commit message

Fix regular expressions to avoid warnings in perl 5.22.

To post a comment you must log in.
Revision history for this message
Phil Wyett (philwyettreb) wrote :

This patch fixes regex issues for building many packages.

The review has now been dormant for over a year. When will it be passed, added to trunk and pushed out as a release?

Reply
Revision history for this message
Heiko Becker (heirecka) wrote :

perl-5.26 made the warnings fatal, so getting this patch should probably be more urgent. I noticed another occurrence of an unescaped left brace though when trying to build at-spi2-core in line 1071:

- $sub = $varhash{$2} if defined $varhash{$2} and $varhash{$2} !~ /\${?$2}?/;
+ $sub = $varhash{$2} if defined $varhash{$2} and $varhash{$2} !~ /\$\{?$2}?/;

Reply

Unmerged revisions

748. By Dominique Leuenberger aka DimStar

Fix regular expressions to avoid warnings in perl 5.22.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: