Tarmac

Merge lp://qastaging/~dobey/tarmac/fix-contributors into lp://qastaging/tarmac

  1. fix-contributors
  2. Merge into main
Proposed by dobey
Status: Merged
Approved by: Paul Hummer
Approved revision: 382
Merged at revision: 382
Proposed branch: lp://qastaging/~dobey/tarmac/fix-contributors
Merge into: lp://qastaging/tarmac
Diff against target: 82 lines (+38/-5)
2 files modified
tarmac/plugins/allowedcontributors.py (+23/-3)
tarmac/plugins/tests/test_allowedcontributors.py (+15/-2)
To merge this branch: bzr merge lp://qastaging/~dobey/tarmac/fix-contributors
Reviewer Review Type Date Requested Status
Paul Hummer Approve
Review via email: mp+40568@code.qastaging.launchpad.net

Commit message

Handle the KeyError with a better error when launchpad.people[team] fails
Use the team.getMembersByStatus API correctly and make multiple calls

To post a comment you must log in.
Revision history for this message
Paul Hummer (rockstar) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches