Tarmac

Merge lp://qastaging/~dobey/tarmac/fix-tests into lp://qastaging/tarmac

  1. fix-tests
  2. Merge into main
Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 409
Merged at revision: 407
Proposed branch: lp://qastaging/~dobey/tarmac/fix-tests
Merge into: lp://qastaging/tarmac
Diff against target: 148 lines (+18/-17)
4 files modified
HACKING (+4/-4)
setup.py (+6/-13)
tarmac/tests/mock.py (+1/-0)
tarmac/tests/test_commands.py (+7/-0)
To merge this branch: bzr merge lp://qastaging/~dobey/tarmac/fix-tests
Reviewer Review Type Date Requested Status
John A Meinel Approve
Review via email: mp+192994@code.qastaging.launchpad.net

Commit message

Fix the tests to run correctly again.
Remove the dependence on twisted trial.

To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

If you are changing away from 'trial' you probably want to change the first line of HACKING "Tests are run using 'trial'...".

Otherwise this looks good to me.

review: Approve
lp://qastaging/~dobey/tarmac/fix-tests updated
409. By dobey

Update the text to refer to setuptools instead of twisted.

Revision history for this message
dobey (dobey) wrote :

Oh, thanks for catching that John. I totally overlooked it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches