Merge lp://qastaging/~dobey/tarmac/fix-votes into lp://qastaging/tarmac
Proposed by
dobey
| Status: | Merged |
|---|---|
| Approved by: | Paul Hummer |
| Approved revision: | 371 |
| Merged at revision: | 372 |
| Proposed branch: | lp://qastaging/~dobey/tarmac/fix-votes |
| Merge into: | lp://qastaging/tarmac |
| Diff against target: |
104 lines (+57/-6) 3 files modified
tarmac/config.py (+15/-0) tarmac/plugins/tests/test_votes.py (+17/-6) tarmac/tests/test_config.py (+25/-0) |
| To merge this branch: | bzr merge lp://qastaging/~dobey/tarmac/fix-votes |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paul Hummer | Approve | ||
|
Review via email:
|
|||
Commit message
Expose [Tarmac] options as attributes on the TarmacConfig object
Wrap set and remove_option so that we can manage TarmacConfig attributes
Fix the global config Votes tests to not set the attributes directly
To post a comment you must log in.
Revision history for this message
| Paul Hummer (rockstar) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
