Merge lp://qastaging/~dobey/tarmac/list-approved into lp://qastaging/tarmac

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 428
Merged at revision: 427
Proposed branch: lp://qastaging/~dobey/tarmac/list-approved
Merge into: lp://qastaging/tarmac
Diff against target: 93 lines (+48/-1)
3 files modified
tarmac/bin/commands.py (+23/-1)
tarmac/bin/options.py (+18/-0)
tarmac/tests/test_commands.py (+7/-0)
To merge this branch: bzr merge lp://qastaging/~dobey/tarmac/list-approved
Reviewer Review Type Date Requested Status
Francis Ginther Approve
David Britton Approve
Review via email: mp+206808@code.qastaging.launchpad.net

Commit message

Add a --list-approved option to the merge command.

Description of the change

With this, running "tarmac merge lp:foo --list-approved" will print out the list of MP URLs for all branches approved for merging into lp:foo. With "tarmac merge --list-approved" omitting the specific branch target, tarmac will print all approved branches for merging into all target branches specified in the tarmac.conf file.

To post a comment you must log in.
Revision history for this message
David Britton (dpb) wrote :

[0] typo on docstring for test:

   *Test* that *--list-approved* option prints..

Looks good! +1

review: Approve
428. By dobey

Fix typos.

Revision history for this message
Francis Ginther (fginther) wrote :

This should resolve part 1 of the feature request as documented in the bug.

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches