Merge lp://qastaging/~dobey/tarmac/lp-api-is-confusing into lp://qastaging/tarmac
Proposed by
dobey
Status: | Merged | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Paul Hummer | ||||||||||||
Approved revision: | 386 | ||||||||||||
Merged at revision: | 386 | ||||||||||||
Proposed branch: | lp://qastaging/~dobey/tarmac/lp-api-is-confusing | ||||||||||||
Merge into: | lp://qastaging/tarmac | ||||||||||||
Diff against target: |
176 lines (+75/-36) 3 files modified
tarmac/plugins/allowedcontributors.py (+25/-14) tarmac/plugins/tests/test_allowedcontributors.py (+43/-21) tarmac/tests/mock.py (+7/-1) |
||||||||||||
To merge this branch: | bzr merge lp://qastaging/~dobey/tarmac/lp-api-is-confusing | ||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Hummer | Approve | ||
Review via email:
|
Commit message
Try to get a LP person object from the API for the author entries
Avoid using getMembersByStatus and just look at lp_team.members instead
Make the Thing mockable object inheret from dict, and be usefully iterable
To post a comment you must log in.