Tarmac

Merge lp://qastaging/~dobey/tarmac/non_ascii-750930 into lp://qastaging/tarmac

Proposed by dobey on 2013-10-30

Status:

Merged

Approved by:

dobey on 2013-10-31

Approved revision:

398

Merged at revision:

410

Proposed branch:

Merge into:

Diff against target:

2 files modified

tarmac/plugins/command.py (+2/-0)
tarmac/plugins/tests/test_command.py (+24/-0)

To merge this branch:

bzr merge lp://qastaging/~dobey/tarmac/non_ascii-750930

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Mike McCracken		2013-10-30	Approve on 2013-10-30
Review via email: mp+193330@code.qastaging.launchpad.net

Decode stdin and stdout rather than joining 8-bit strings as unicode.

398. By dobey on 2013-10-30: Set decode error level to replace, to handle invalid UTF-8 as well.
Add a comment to the test explaining the weird string in a string, with bug #.

Revision history for this message

Mike McCracken (mikemc) wrote on 2013-10-30:

Thanks for the clarifications.

review: Approve

Revision history for this message

John A Meinel (jameinel) wrote on 2013-10-31:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-10-31 0:40, Rodney Dawes wrote:
> Rodney Dawes has proposed merging lp:~dobey/tarmac/non_ascii-750930
> into lp:tarmac.
>
> Commit message: Decode stdin and stdout rather than joining 8-bit
> strings as unicode.
>
> Requested reviews: Tarmac Developers (tarmac-devs)
>
> For more details, see:
> https://code.launchpad.net/~dobey/tarmac/non_ascii-750930/+merge/193330
>
>
review: approve