Merge lp://qastaging/~dobey/tarmac/recipe-success-only into lp://qastaging/tarmac
Proposed by
dobey
| Status: | Merged |
|---|---|
| Approved by: | Paul Hummer |
| Approved revision: | 402 |
| Merged at revision: | 401 |
| Proposed branch: | lp://qastaging/~dobey/tarmac/recipe-success-only |
| Merge into: | lp://qastaging/tarmac |
| Diff against target: |
54 lines (+9/-3) 2 files modified
tarmac/bin/commands.py (+3/-2) tarmac/plugins/recipebuilder.py (+6/-1) |
| To merge this branch: | bzr merge lp://qastaging/~dobey/tarmac/recipe-success-only |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paul Hummer | Approve | ||
|
Review via email:
|
|||
Commit message
Only trigger recipe builds when at least one branch of a merge succeeds.
To post a comment you must log in.
Revision history for this message
| Paul Hummer (rockstar) | # |
review:
Approve
Revision history for this message
| Paul Hummer (rockstar) wrote | # |
Revision history for this message
| Paul Hummer (rockstar) | # |
review:
Needs Fixing
Revision history for this message
| Paul Hummer (rockstar) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
39 + def run(self, command, target, success_count):
Upon further looking at this, I think I'd rather have the function signature be
run(self, command, target, kwargs):
This way, you can add other arguments easily.