Merge lp://qastaging/~dobey/tarmac/review-url into lp://qastaging/tarmac
Proposed by
dobey
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Paul Hummer | ||||
| Approved revision: | 371 | ||||
| Merged at revision: | 370 | ||||
| Proposed branch: | lp://qastaging/~dobey/tarmac/review-url | ||||
| Merge into: | lp://qastaging/tarmac | ||||
| Prerequisite: | lp://qastaging/~dobey/tarmac/votes-trustedreviewer | ||||
| Diff against target: |
98 lines (+48/-22) 2 files modified
tarmac/bin/commands.py (+2/-2) tarmac/tests/test_commands.py (+46/-20) |
||||
| To merge this branch: | bzr merge lp://qastaging/~dobey/tarmac/review-url | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paul Hummer | Approve | ||
|
Review via email:
|
|||
Commit message
Fix the regex for merge urls to support non-beta API and link to code.lp
Add a test to check that the merge urls get substituted correctly
To post a comment you must log in.
Revision history for this message
| Paul Hummer (rockstar) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
