Merge lp://qastaging/~dobey/tarmac/use-add-hook into lp://qastaging/tarmac
Proposed by
dobey
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Paul Hummer | ||||
| Approved revision: | 401 | ||||
| Merged at revision: | 399 | ||||
| Proposed branch: | lp://qastaging/~dobey/tarmac/use-add-hook | ||||
| Merge into: | lp://qastaging/tarmac | ||||
| Diff against target: |
139 lines (+48/-40) 2 files modified
tarmac/bin/commands.py (+8/-8) tarmac/hooks.py (+40/-32) |
||||
| To merge this branch: | bzr merge lp://qastaging/~dobey/tarmac/use-add-hook | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paul Hummer | Approve | ||
| Sidnei da Silva (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Stop using the deprecated create_hook, and use add_hook instead
Get rid of the TarmacHookPoint class as we can't use it with add_hook
Move the custom fire method to the hooks registry instead
Update the code to fire hooks using the new method on the hook registry
Description of the change
We need this as bzr 2.6 removes the create_hook method which was deprecated in 2.4, but which tarmac was still using.
To post a comment you must log in.
Revision history for this message
| Paul Hummer (rockstar) | # |
review:
Approve
Revision history for this message
| Paul Hummer (rockstar) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good. +1!