Merge lp://qastaging/~dobey/ubuntu-app-launch/throw-less into lp://qastaging/ubuntu-app-launch/16.10
Proposed by
dobey
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Ted Gould | ||||
Approved revision: | 256 | ||||
Merged at revision: | 256 | ||||
Proposed branch: | lp://qastaging/~dobey/ubuntu-app-launch/throw-less | ||||
Merge into: | lp://qastaging/ubuntu-app-launch/16.10 | ||||
Diff against target: |
23 lines (+11/-3) 1 file modified
libubuntu-app-launch/application-impl-libertine.cpp (+11/-3) |
||||
To merge this branch: | bzr merge lp://qastaging/~dobey/ubuntu-app-launch/throw-less | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
unity-api-1-bot | continuous-integration | Needs Fixing | |
Ted Gould (community) | Approve | ||
Review via email: mp+307062@code.qastaging.launchpad.net |
Commit message
Add a try/catch inside the for loop in ::list().
Description of the change
For some reason the Libertine back-end was the only one not doing this. This adds a try/catch inside the for loop for listing installed apps, as relying on the application using the API to handle exceptions from here still results in a broken listing of apps, as the loop would never complete when an exception was thrown. So we need to log and continue on, as the other back-ends do, here.
To post a comment you must log in.
FAILED: Continuous integration, rev:256 /jenkins. canonical. com/unity- api-1/job/ lp-ubuntu- app-launch- ci/107/ /jenkins. canonical. com/unity- api-1/job/ build/790/ console /jenkins. canonical. com/unity- api-1/job/ build-0- fetch/796 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= vivid+overlay/ 604/console /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 604 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 604/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= yakkety/ 604 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= yakkety/ 604/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= vivid+overlay/ 604 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= vivid+overlay/ 604/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 604 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 604/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= yakkety/ 604 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= yakkety/ 604/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= vivid+overlay/ 604 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= vivid+overlay/ 604/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 604 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 604/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= yakkety/ 604 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= yakkety/ 604/artifact/ output/ *zip*/output. zip
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild: /jenkins. canonical. com/unity- api-1/job/ lp-ubuntu- app-launch- ci/107/ rebuild
https:/