Merge lp://qastaging/~dobey/ubuntuone-client/type-init-depr into lp://qastaging/ubuntuone-client

A minor point, since I was just a little confused, this might be more readable if you used GLIB_CHECK_VERSION:
http://developer.gnome.org/glib/2.28/glib-Version-Information.html#GLIB-CHECK-VERSION:CAPS

#if !GLIB_CHECK_VERSION(2, 36, 0))
    g_type_init();
#endif

Approving anyway, you can change it if you agree.

On Thu, 2013-01-17 at 20:02 +0000, Mike McCracken wrote:
> Review: Approve
>
>
> A minor point, since I was just a little confused, this might be more readable if you used GLIB_CHECK_VERSION:
> http://developer.gnome.org/glib/2.28/glib-Version-Information.html#GLIB-CHECK-VERSION:CAPS
>
> #if !GLIB_CHECK_VERSION(2, 36, 0))
> g_type_init();
> #endif
>
> Approving anyway, you can change it if you agree.

This actually won't work here. The version is not yet 2.36.0, but the
API version is 2.36 (and so GLIB_VERSION_2_36 is defined in the headers,
but GLIB_CHECK_VERSION checks against the
GLIB_{MAJOR,MINOR,MICRO}_VERSION defines, which match up with the actual
release version. The actual released version right now, is 2.35.4, so
using this macro would fail and the deprecation warning would still
happen until the actual released version was 2.36.0. We could use 2.35.4
here instead of course, but I think it's better to use the API version
defines for this, rather than the check macro, which would be better to
require a certain stable release for a bug fix or something, which made
it into a minor release, but isn't part of the API necessarily.

Ah, ok - thanks for the explanation!