Merge lp://qastaging/~dobey/ubuntuone-control-panel/update-4-2 into lp://qastaging/ubuntuone-control-panel/stable-4-2
Proposed by
dobey
Status: | Merged |
---|---|
Approved by: | dobey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 381 |
Proposed branch: | lp://qastaging/~dobey/ubuntuone-control-panel/update-4-2 |
Merge into: | lp://qastaging/ubuntuone-control-panel/stable-4-2 |
Diff against target: |
369 lines (+103/-57) 8 files modified
ubuntuone/controlpanel/backend.py (+6/-3) ubuntuone/controlpanel/gui/qt/main/darwin.py (+14/-3) ubuntuone/controlpanel/gui/qt/main/tests/test_darwin.py (+44/-34) ubuntuone/controlpanel/tests/test_backend.py (+9/-3) ubuntuone/controlpanel/tests/test_web_client.py (+9/-4) ubuntuone/controlpanel/utils/darwin.py (+13/-2) ubuntuone/controlpanel/utils/tests/test_darwin.py (+6/-6) ubuntuone/controlpanel/utils/tests/test_linux.py (+2/-2) |
To merge this branch: | bzr merge lp://qastaging/~dobey/ubuntuone-control-panel/update-4-2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mike McCracken (community) | Approve | ||
Review via email:
|
Commit message
[Mike McCracken]
- Use officially recommended API for creating file URLs. (LP: #1112792)
- Change quit handler to quit immediately. (LP: #1042834)
[Rodney Dawes]
- Append query arguments to the URI, rather than passing in as parameters.
- Fix new pyflakes warnings about variable redefinition in list comprehensions.
To post a comment you must log in.
The attempt to merge lp:~dobey/ubuntuone-control-panel/update-4-2 into lp:ubuntuone-control-panel/stable-4-2 failed. Below is the output from the failed tests.
*** Running DBus test suite *** controlpanel. dbustests. test_dbus_ service inTestCase dbus_service_ cant_register ... Control panel backend already running.
[OK] dbus_service_ main ... [OK] stCase cant_register_ twice ... [SKIPPED] dbus_busname_ created ... [OK] error_handler_ default ... [OK] error_handler_ with_exception ... [OK] error_handler_ with_failure ... [OK] error_handler_ with_non_ string_ dict ... [OK] error_handler_ with_string_ dict ... [OK] register_ service ... [OK] file_sync_ status_ changed ... [OK] file_sync_ status_ disabled ... [OK] file_sync_ status_ disconnected ... [OK] file_sync_ status_ error ... [OK] file_sync_ status_ idle ... [OK] file_sync_ status_ starting ... [OK] file_sync_ status_ stopped ... [OK] file_sync_ status_ syncing ... [OK] file_sync_ status_ unknown ... [OK] status_ changed_ handler ... [OK] status_ changed_ handler_ after_status_ requested ... [OK] status_ changed_ handler_ after_status_ requested_ twice ... [OK] hErrorTestCase account_ info_returned ... [OK] change_ device_ settings ... [OK] change_ replication_ settings ... [OK] change_ volume_ settings ... [OK] connect_ files ... [OK] devices_ info_returned ... [OK] disable_ files ... [OK] disconnect_ files ... [OK] enable_ files ... [OK] remove_ device ... [OK] replications_ info ... [OK] restart_ files ... [OK]
ubuntuone.
BaseTestCase
runTest ... [OK]
DBusServiceMa
test_
test_
DBusServiceTe
test_
test_
test_
test_
test_
test_
test_
test_
FileSyncTestCase
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
OperationsAut
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
test_
t...