Merge lp://qastaging/~dobey/ubuntuone-installer/new-logo into lp://qastaging/ubuntuone-installer

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 28
Merged at revision: 31
Proposed branch: lp://qastaging/~dobey/ubuntuone-installer/new-logo
Merge into: lp://qastaging/ubuntuone-installer
Diff against target: 93 lines (+22/-7)
2 files modified
data/u1logo.svg (+19/-0)
ubuntuone/installer/gui.py (+3/-7)
To merge this branch: bzr merge lp://qastaging/~dobey/ubuntuone-installer/new-logo
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
Lisette Slegers (community) Approve
Review via email: mp+107280@code.qastaging.launchpad.net

Commit message

Replace the logo with an SVG with better proportions

Description of the change

For a screenshot of the installer with the new logo, see: http://ubuntuone.com/0nEaIGiMba09ObquJ2Ul41

To post a comment you must log in.
Revision history for this message
Lisette Slegers (lisette-slegers) wrote :

The top of the U1 shape part of the logo should be aligned 12px from the top, not the top of the 'b'. It looks visually off now, but I understand it is impossible to lift the logo image up by 6px, without moving the text up too. We should consider using the alternative brand mark to avoid this in future versions.

review: Approve
Revision history for this message
dobey (dobey) wrote :

http://ubuntuone.com/0uP8qddPaI9dfFaiNCRMHi is a screen shot of the installer with fixed spacing of the content.

Revision history for this message
Manuel de la Peña (mandel) wrote :

Can we have some tests added for this, I'm not that concern about adding tests for the spacing (that is just stupid) but I'd like to see at least a test asserting that the correct logo is used.

Also AFAIK the data/u1logo.svg is not present in the setup.py, is that intentional? I thin that we should ensure that if a user uses the setup.py all the required data is copied.

review: Needs Fixing
Revision history for this message
dobey (dobey) wrote :

How do you mean to "test that the correct logo is used" exactly?

The image is picked up automatically, as it was before, by DistutilsExtra.auto.

Revision history for this message
Manuel de la Peña (mandel) :
review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

The attempt to merge lp:~dobey/ubuntuone-installer/new-logo into lp:ubuntuone-installer failed. Below is the output from the failed tests.

Traceback (most recent call last):
  File "/usr/bin/u1trial", line 337, in <module>
    main()
  File "/usr/bin/u1trial", line 317, in main
    suite = trial_runner.get_suite(config)
  File "/usr/bin/u1trial", line 196, in get_suite
    config['ignore-paths']))
  File "/usr/bin/u1trial", line 180, in _collect_tests
    module_suite = self._load_unittest(filepath)
  File "/usr/bin/u1trial", line 120, in _load_unittest
    module = __import__(modpath, None, None, [""])
  File "/mnt/tarmac/cache/ubuntuone-installer/trunk/ubuntuone/installer/tests/test_gui.py", line 18, in <module>
    from gi.repository import Gtk
  File "/usr/lib/python2.7/dist-packages/gi/importer.py", line 76, in load_module
    dynamic_module._load()
  File "/usr/lib/python2.7/dist-packages/gi/module.py", line 224, in _load
    overrides_modules = __import__('gi.overrides', fromlist=[self._namespace])
  File "/usr/lib/python2.7/dist-packages/gi/overrides/Gtk.py", line 1533, in <module>
    raise RuntimeError("Gtk couldn't be initialized")
RuntimeError: Gtk couldn't be initialized

Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

The attempt to merge lp:~dobey/ubuntuone-installer/new-logo into lp:ubuntuone-installer failed. Below is the output from the failed tests.

Traceback (most recent call last):
  File "/usr/bin/u1trial", line 337, in <module>
    main()
  File "/usr/bin/u1trial", line 317, in main
    suite = trial_runner.get_suite(config)
  File "/usr/bin/u1trial", line 196, in get_suite
    config['ignore-paths']))
  File "/usr/bin/u1trial", line 180, in _collect_tests
    module_suite = self._load_unittest(filepath)
  File "/usr/bin/u1trial", line 120, in _load_unittest
    module = __import__(modpath, None, None, [""])
  File "/mnt/tarmac/cache/ubuntuone-installer/trunk/ubuntuone/installer/tests/test_gui.py", line 21, in <module>
    from ubuntuone.installer import gui
  File "/mnt/tarmac/cache/ubuntuone-installer/trunk/ubuntuone/installer/gui.py", line 18, in <module>
    import aptdaemon.gtk3widgets as aptgtk
ImportError: No module named aptdaemon.gtk3widgets

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: